相关代码优化

alien-store/src/main/java/shop/alien/store/service/impl/LifeDiscountCouponServiceImpl.java

@@ -69,7 +69,6 @@ public class LifeDiscountCouponServiceImpl extends ServiceImpl<LifeDiscountCoupo
 
     @Override
     public boolean addDiscountCoupon(LifeDiscountCouponDto lifeDiscountCouponDto) {
-
         try {
             //发布优惠券表信息
             LifeDiscountCoupon lifeDiscountCoupon = new LifeDiscountCoupon();
@@ -110,6 +109,7 @@ public class LifeDiscountCouponServiceImpl extends ServiceImpl<LifeDiscountCoupo
             }
             lifeDiscountCouponUnavailableRules.setUnavailableRuleValue(lifeDiscountCouponDto.getClaimRule());
             lifeDiscountCouponUnavailableRulesMapper.insert(lifeDiscountCouponUnavailableRules);
+
             //指定时间段可用规则
             List<LifeDiscountCouponQuantumRules> availableTimeQuantumList =  lifeDiscountCouponDto.getAvailableTimeQuantum();
             if(CollectionUtils.isNotEmpty(availableTimeQuantumList)){
@@ -118,6 +118,7 @@ public class LifeDiscountCouponServiceImpl extends ServiceImpl<LifeDiscountCoupo
                 });
                 lifeDiscountCouponQuantumRulesService.saveBatch(availableTimeQuantumList);
             }
+
             //自定义时间段不可用规则
             List<LifeDiscountCouponQuantumRules> customizeUnavailableTimeQuantumList =  lifeDiscountCouponDto.getCustomizeUnavailableTimeQuantum();
             if(CollectionUtils.isNotEmpty(customizeUnavailableTimeQuantumList)) {
@@ -127,7 +128,7 @@ public class LifeDiscountCouponServiceImpl extends ServiceImpl<LifeDiscountCoupo
                 lifeDiscountCouponQuantumRulesService.saveBatch(customizeUnavailableTimeQuantumList);
             }
         } catch (BeansException e) {
-            e.printStackTrace();
+            log.error("LifeDiscountCouponServiceImpl.receiveCoupon ERROR Msg=" + e.getMessage());
             return false;
         }
         return true;
@@ -166,12 +167,12 @@ public class LifeDiscountCouponServiceImpl extends ServiceImpl<LifeDiscountCoupo
             lifeDiscountCouponUnavailableRules.setUnavailableRuleValue(lifeDiscountCouponDto.getClaimRule());
             lifeDiscountCouponUnavailableRulesMapper.insert(lifeDiscountCouponUnavailableRules);
 
-            // 删除时间段规则信息
+            // 删除优惠券时间段规则信息
             LambdaQueryWrapper<LifeDiscountCouponQuantumRules> lifeDiscountCouponQuantumRulesLambdaQueryWrapper = new LambdaQueryWrapper<>();
             lifeDiscountCouponQuantumRulesLambdaQueryWrapper.eq(LifeDiscountCouponQuantumRules::getDiscountCouponId, lifeDiscountCoupon.getId());
             lifeDiscountCouponQuantumRulesMapper.delete(lifeDiscountCouponQuantumRulesLambdaQueryWrapper);
 
-            //指定时间段可用规则
+            // 保存指定时间段可用规则
             List<LifeDiscountCouponQuantumRules> availableTimeQuantumList =  lifeDiscountCouponDto.getAvailableTimeQuantum();
             if(CollectionUtils.isNotEmpty(availableTimeQuantumList)){
                 availableTimeQuantumList.forEach(availableTimeQuantum->{
@@ -179,7 +180,7 @@ public class LifeDiscountCouponServiceImpl extends ServiceImpl<LifeDiscountCoupo
                 });
                 lifeDiscountCouponQuantumRulesService.saveBatch(availableTimeQuantumList);
             }
-            //自定义时间段不可用规则
+            // 保存自定义时间段不可用规则
             List<LifeDiscountCouponQuantumRules> customizeUnavailableTimeQuantumList =  lifeDiscountCouponDto.getCustomizeUnavailableTimeQuantum();
             if(CollectionUtils.isNotEmpty(customizeUnavailableTimeQuantumList)) {
                 customizeUnavailableTimeQuantumList.forEach(customizeUnavailableTimeQuantum->{
@@ -189,7 +190,7 @@ public class LifeDiscountCouponServiceImpl extends ServiceImpl<LifeDiscountCoupo
             }
 
         } catch (BeansException e) {
-            e.printStackTrace();
+            log.error("LifeDiscountCouponServiceImpl.editDiscountCoupon ERROR Msg=" + e.getMessage());
             return false;
         }
         return true;